build-tests: The allowed method is used by default #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The allowed method returns true when the feature is set to `enabled` or `auto`. The allowed method returns false when the feature is set to `disabled`. So we prefer to use the `allowed` method instead of `enabled`. Signed-off-by: George Liu <[email protected]> Change-Id: I3cc28241cd9ef0d907aa73409a63a4470a628e70
GiridhariKrishnan
requested review from
SunnySrivastava1984,
PriyangaRamasamy and
jinuthomas
jinuthomas
approved these changes
Jan 5, 2024
jinuthomas
requested changes
Jan 5, 2024
jinuthomas
reviewed
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The allowed method returns true when the feature is set to
enabledorauto.The allowed method returns false when the feature is set to
disabled.So we prefer to use the
allowedmethod instead ofenabled.Change-Id: I3cc28241cd9ef0d907aa73409a63a4470a628e70