Update JDK8 windows compiles to use Visual Studio 2013 #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdekonin
changed the title
jdekonin
force-pushed
the
windows
branch
2 times, most recently
from
b57b4da to
cedce30
Compare
jdekonin
changed the title
|
Needs to merge with eclipse-openj9/openj9#10892 |
keithc-ca
requested changes
Oct 21, 2020
keithc-ca
approved these changes
Oct 27, 2020
|
@pshipton I'll let you merge this and eclipse-openj9/openj9#10892 when you get satisfactory answers from Joe. |
pshipton
approved these changes
Oct 27, 2020
|
Hmm, I'm thinking that once this is merged all builds need to use VS2013 or they will fail. That includes builds at Adopt. adoptium/temurin-build#466 (comment) |
|
@jdekonin there is a merge conflict here. |
jdekonin
added a commit
to jdekonin/openj9-openjdk-jdk8
that referenced
this pull request
Nov 4, 2020
* [skip ci] * disable the use of rebase * eclipse-openj9/openj9#10129 Signed-off-by: Joe deKoning <[email protected]>
* [skip ci] * disable the use of rebase * eclipse-openj9/openj9#10129 Signed-off-by: Joe deKoning <[email protected]>
|
Rebase performed and conflict resolved @pshipton |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joe deKoning [email protected]