🐛 Fix crashing app when deleting (konveyor#1202)

Resolves https://issues.redhat.com/browse/MTA-1041 Signed-off-by: ibolton336 <[email protected]>
ibolton336 · Jul 26, 2023 · 92bf4c7 · 92bf4c7
1 parent ca340c0
commit 92bf4c7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/client/src/app/pages/applications/applications-table-analyze/applications-table-analyze.tsx b/client/src/app/pages/applications/applications-table-analyze/applications-table-analyze.tsx
@@ -204,15 +204,14 @@ export const ApplicationsTableAnalyze: React.FC = () => {
       }),
       variant: "success",
     });
-    refetch();
+    activeAppInDetailDrawer && closeDetailDrawer();
   };
 
   const onDeleteApplicationError = (error: AxiosError) => {
     pushNotification({
       title: getAxiosErrorMessage(error),
       variant: "danger",
     });
-    refetch();
   };
 
   const { mutate: deleteApplication } = useDeleteApplicationMutation(

diff --git a/...rc/app/pages/applications/applications-table-assessment/applications-table-assessment.tsx b/...rc/app/pages/applications/applications-table-assessment/applications-table-assessment.tsx
@@ -192,15 +192,14 @@ export const ApplicationsTable: React.FC = () => {
     fetchApplications();
   };
 
-  // Delete
   const onDeleteApplicationSuccess = (appIDCount: number) => {
     pushNotification({
       title: t("toastr.success.applicationDeleted", {
         appIDCount: appIDCount,
       }),
       variant: "success",
     });
-    fetchApplications();
+    activeAppInDetailDrawer && closeDetailDrawer();
   };
 
   const onDeleteApplicationError = (error: AxiosError) => {

diff --git a/client/src/app/queries/assessments.ts b/client/src/app/queries/assessments.ts
@@ -32,7 +32,7 @@ export const useFetchApplicationAssessments = (
     if (application.id) queryResultsByAppId[application.id] = queryResults[i];
   });
   return {
-    getApplicationAssessment: (id: number) => queryResultsByAppId[id].data,
+    getApplicationAssessment: (id: number) => queryResultsByAppId[id]?.data,
     isLoadingApplicationAssessment: (id: number) =>
       queryResultsByAppId[id].isLoading,
     fetchErrorApplicationAssessment: (id: number) =>