Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made animated scroll #6

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

made animated scroll #6

wants to merge 7 commits into from

Conversation

ibrkhalil
Copy link
Owner

No description provided.

@ibrkhalil ibrkhalil requested a review from mcherri September 28, 2021 13:29
mcherri
mcherri requested changes Sep 29, 2021
View reviewed changes
components/rowListScene.brs Outdated Show resolved Hide resolved
components/rowListScene.brs Show resolved Hide resolved
components/rowListScene.brs Outdated Show resolved Hide resolved
mcherri
mcherri requested changes Oct 7, 2021
View reviewed changes
Copy link
Collaborator

@mcherri mcherri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is still buggy. We lose focus when we scroll horizontally.

2021-10-07-175949.mp4

@ibrkhalil
Copy link
Owner Author

Done

mcherri
mcherri requested changes Oct 15, 2021
View reviewed changes
Copy link
Collaborator

@mcherri mcherri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are close. I still cannot scroll to the last element once I reach it once.

bug.mp4

.history/components/rowListScene_20211008141935.xml
@@ -0,0 +1,17 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file here?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted.

.history/components/rowListScene_20211008142233.xml
@@ -0,0 +1,17 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before

.history/components/rowListScene_20211008142249.xml
@@ -0,0 +1,17 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before

.history/components/rowListScene_20211008142332.xml
@@ -0,0 +1,17 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before

.history/components/rowListScene_20211008142828.xml
@@ -0,0 +1,17 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before

.history/components/rowListScene_20211008142829.xml
@@ -0,0 +1,17 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcherri mcherri mcherri requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibrkhalil @mcherri