Upgrade to JakartaEE 10 API for compatibility with Payara 6 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've made changes to icat-ansible and manually re-run the CI which is now succeeding: https://github.com/icatproject/ids.server/actions/runs/5786590806 |
- update OS to Ubuntu 22.04 - use OS python version - add Java 17 to version matrix - run apt-get update - remove installation of python3-lxml which is now done by icat-ansible
RKrahl
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Looks good to me. The one comment in the code is just meant to set a reminder.
There is one issue with Miredot failing to create the REST API documentation. It seems to be the same issue as in icatproject/icat.server#310. I get the error message:
[INFO] --- miredot-plugin:2.4.1-Java11:restdoc (miredot) @ ids.server ---
[WARNING] Rest Framework not explicitly set, using JAX-RS by default.
[INFO] Building reflective model of API and reading annotations...
[ERROR] Your project doesn't contain any REST interfaces, so no output will be generated.
Maybe it is incorrectly configured.
But I'd prefer to deal with that in a separate issue after merging this PR.
@ajkyffin: you were still adding commits recently. Are you done with this?
| # ICAT Ansible clone and install dependencies | ||
| - name: Checkout icat-ansible | ||
| uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0 | ||
| with: | ||
| repository: icatproject-contrib/icat-ansible | ||
| path: icat-ansible | ||
| ref: master | ||
| ref: payara6 |
There was a problem hiding this comment.
I guess that will need to be changed back to master as soon as icatproject-contrib/icat-ansible#84 gets merged.
RKrahl
added
the
compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key changes in this PR are:
javaxnamespace are changed to thejakartanamespace.The first 2 changes are not backwards-compatible so this is a new major version.