Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support built-in loader of compilation #6

Merged
merged 11 commits into from
Nov 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/binding_options/src/options/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ use serde::Deserialize;

use rspack_binding_options::{
RawBuiltins, RawCacheOptions, RawContext, RawDevServer, RawDevtool, RawExperiments,
RawMode, RawNodeOption, RawOutputOptions, RawResolveOptions, RawOptimizationOptions,
RawSnapshotOptions, RawStatsOptions, RawTarget, RawModuleOptions, RawOptionsApply,
RawMode, RawNodeOption, RawOutputOptions, RawResolveOptions, RawOptionsApply,
RawSnapshotOptions, RawStatsOptions, RawTarget, RawModuleOptions,
};

mod raw_module;
Expand Down
6 changes: 5 additions & 1 deletion crates/binding_options/src/options/raw_module.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ pub fn get_builtin_loader(builtin: &str, options: Option<&str>) -> BoxLoader {

if builtin.starts_with(COMPILATION_LOADER_IDENTIFIER) {
return Arc::new(
loader_compilation::CompilationLoader::default().with_identifier(builtin.into()),
loader_compilation::CompilationLoader::new(
serde_json::from_str(options.unwrap_or("{}")).unwrap_or_else(|e| {
panic!("Could not parse builtin:compilation-loader options:{options:?},error: {e:?}")
}),
).with_identifier(builtin.into()),
);
}

Expand Down
7 changes: 7 additions & 0 deletions crates/loader_compilation/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,18 @@ edition = "2021"
[dependencies]
anyhow = { workspace = true }
async-trait = { workspace = true }
dashmap = { workspace = true }
either = "1"
fxhash = "0.2.1"
lazy_static = "1.4.0"
once_cell = { workspace = true }
rspack_ast = { path = "../.rspack_crates/rspack_ast" }
rspack_core = { path = "../.rspack_crates/rspack_core" }
rspack_error = { path = "../.rspack_crates/rspack_error" }
rspack_loader_runner = { path = "../.rspack_crates/rspack_loader_runner" }
rspack_plugin_javascript = { path = "../.rspack_crates/rspack_plugin_javascript" }
rspack_regex = { path = "../.rspack_crates/rspack_regex" }
regex = { workspace = true }
serde = { workspace = true, features = ["derive"] }
serde_json = "1.0.100"
swc_config = { workspace = true }
Expand Down
250 changes: 250 additions & 0 deletions crates/loader_compilation/src/compiler.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,250 @@
use std::env;
use std::{path::PathBuf, sync::Arc};
use anyhow::{Context, Error};
use dashmap::DashMap;
use rspack_ast::javascript::{Ast as JsAst, Context as JsAstContext, Program as JsProgram};
use swc_core:: {
base::{
config::{Options, JsMinifyCommentOption, BuiltInput, IsModule},
try_with_handler, SwcComments
},
common::{
Globals, SourceFile, SourceMap, GLOBALS, Mark, FileName, FilePathMapping, BytePos,
comments::{SingleThreadedComments, Comments, Comment, CommentKind},
errors::{Handler, HANDLER},
},
ecma::{transforms::base::helpers::{self, Helpers}, ast::{Program, EsVersion}, visit::{Fold, FoldWith},
parser::{parse_file_as_module, Syntax, parse_file_as_script, parse_file_as_program}},
};
use swc_config::config_types::BoolOr;

fn minify_file_comments(
comments: &SingleThreadedComments,
preserve_comments: BoolOr<JsMinifyCommentOption>,
) {
match preserve_comments {
BoolOr::Bool(true) | BoolOr::Data(JsMinifyCommentOption::PreserveAllComments) => {}

BoolOr::Data(JsMinifyCommentOption::PreserveSomeComments) => {
let preserve_excl = |_: &BytePos, vc: &mut Vec<Comment>| -> bool {
// Preserve license comments.
//
// See https://github.com/terser/terser/blob/798135e04baddd94fea403cfaab4ba8b22b1b524/lib/output.js#L175-L181
vc.retain(|c: &Comment| {
c.text.contains("@lic")
|| c.text.contains("@preserve")
|| c.text.contains("@copyright")
|| c.text.contains("@cc_on")
|| (c.kind == CommentKind::Block && c.text.starts_with('!'))
});
!vc.is_empty()
};
let (mut l, mut t) = comments.borrow_all_mut();

l.retain(preserve_excl);
t.retain(preserve_excl);
}

BoolOr::Bool(false) => {
let (mut l, mut t) = comments.borrow_all_mut();
l.clear();
t.clear();
}
}
}

pub(crate) struct SwcCompiler {
cm: Arc<SourceMap>,
fm: Arc<SourceFile>,
comments: SingleThreadedComments,
options: Options,
globals: Globals,
helpers: Helpers,
}

impl SwcCompiler {
pub fn new(resource_path: PathBuf, source: String, mut options: Options) -> Result<Self, Error> {
let cm = Arc::new(SourceMap::new(FilePathMapping::empty()));
let globals = Globals::default();
GLOBALS.set(&globals, || {
let top_level_mark = Mark::new();
let unresolved_mark = Mark::new();
options.top_level_mark = Some(top_level_mark);
options.unresolved_mark = Some(unresolved_mark);
});
// TODO: support read config of .swcrc.
let fm = cm.new_source_file(FileName::Real(resource_path), source);
let comments = SingleThreadedComments::default();
let helpers = GLOBALS.set(&globals, || {
let external_helpers = options.config.jsc.external_helpers;
Helpers::new(external_helpers.into())
});

Ok(Self {
cm,
fm,
comments,
options,
globals,
helpers,
})
}

pub fn run<R>(&self, op: impl FnOnce() -> R) -> R {
GLOBALS.set(&self.globals, op)
}

fn parse_js(
&self,
fm: Arc<SourceFile>,
handler: &Handler,
target: EsVersion,
syntax: Syntax,
is_module: IsModule,
comments: Option<&dyn Comments>,
) -> Result<Program, Error> {
let mut error = false;
let mut errors = vec![];

let program_result = match is_module {
IsModule::Bool(true) => {
parse_file_as_module(&fm, syntax, target, comments, &mut errors).map(Program::Module)
}
IsModule::Bool(false) => {
parse_file_as_script(&fm, syntax, target, comments, &mut errors).map(Program::Script)
}
IsModule::Unknown => parse_file_as_program(&fm, syntax, target, comments, &mut errors),
};

for e in errors {
e.into_diagnostic(handler).emit();
error = true;
}

let mut res = program_result.map_err(|e| {
e.into_diagnostic(handler).emit();
Error::msg("Syntax Error")
});

if error {
return Err(anyhow::anyhow!("Syntax Error"));
}

if env::var("SWC_DEBUG").unwrap_or_default() == "1" {
res = res.with_context(|| format!("Parser config: {:?}", syntax));
}

res

}

pub fn parse<'a, P>(
&'a self,
program: Option<Program>,
before_pass: impl FnOnce(&Program) -> P + 'a,
) -> Result<BuiltInput<impl Fold + 'a>, Error>
where
P: Fold + 'a,
{
let built = self.run(|| {
try_with_handler(self.cm.clone(), Default::default(), |handler| {
let built = self.options.build_as_input(
&self.cm,
&self.fm.name,
move |syntax, target, is_module| match program {
Some(v) => Ok(v),
_ => self.parse_js(
self.fm.clone(),
handler,
target,
syntax,
is_module,
Some(&self.comments),
),
},
self.options.output_path.as_deref(),
self.options.source_file_name.clone(),
handler,
// TODO: support config file.
Some(self.options.config.clone()),
Some(&self.comments),
before_pass,
)?;

Ok(Some(built))
})
})?;

match built {
Some(v) => Ok(v),
None => {
anyhow::bail!("cannot process file because it's ignored by .swcrc")
}
}
}

pub fn transform(&self, config: BuiltInput<impl Fold>) -> Result<Program, Error> {
let program = config.program;
let mut pass = config.pass;

let program = self.run(|| {
helpers::HELPERS.set(&self.helpers, || {
try_with_handler(self.cm.clone(), Default::default(), |handler| {
HANDLER.set(handler, || {
// Fold module
Ok(program.fold_with(&mut pass))
})
})
})
});
if let Some(comments) = &config.comments {
minify_file_comments(comments, config.preserve_comments);
};

program
}
}

pub(crate) trait IntoJsAst {
fn into_js_ast(self, program: Program) -> JsAst;
}

impl IntoJsAst for SwcCompiler {
fn into_js_ast(self, program: Program) -> JsAst {
JsAst::default()
.with_program(JsProgram::new(
program,
Some(self.comments.into_swc_comments()),
))
.with_context(JsAstContext {
globals: self.globals,
helpers: self.helpers,
source_map: self.cm,
top_level_mark: self
.options
.top_level_mark
.expect("`top_level_mark` should be initialized"),
unresolved_mark: self
.options
.unresolved_mark
.expect("`unresolved_mark` should be initialized"),
})
}
}

trait IntoSwcComments {
fn into_swc_comments(self) -> SwcComments;
}

impl IntoSwcComments for SingleThreadedComments {
fn into_swc_comments(self) -> SwcComments {
let (l, t) = {
let (l, t) = self.take_all();
(l.take(), t.take())
};
SwcComments {
leading: Arc::new(DashMap::from_iter(l.into_iter())),
trailing: Arc::new(DashMap::from_iter(t.into_iter())),
}
}
}
Loading