Skip to content

Commit

Permalink
Added documentation note to class for be avaible by the API viewer.
Browse files Browse the repository at this point in the history
Also done a little change about special characters, there is no issues with them.
  • Loading branch information
yybalam committed Aug 30, 2016
1 parent 67bbce1 commit 41cdf39
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

## Breaking changes

* [qx.bom.Cookie] Previous versions of qooxoo use `escape()` and `unescape()` functions. Since those functions are deprecated, then now qooxdoo use `encodeURIComponent()` and `decodeURIComponent()` functions. This may break some cookies. There no must be issues with special characters like `~!@#$%^&*(){}[]=:/,;?+\'"\\` but some unicode characters like `äëíöü` (etc) are encoded different by `escape()` and `encodeURIComponent()`, so you must take care of this change if you use unicode characters.
* [qx.bom.Cookie] Previous versions of qooxoo use `escape()` and `unescape()` functions. Since those functions are deprecated, then now qooxdoo use `encodeURIComponent()` and `decodeURIComponent()` functions. This may break some cookies. There are no issues with special characters like `~!@#$%^&*(){}[]=:/,;?+\'"\\` but some unicode characters like `äëíöü` (etc) are encoded different by `escape()` and `encodeURIComponent()`, so you must take care of this change if you use unicode characters.
7 changes: 7 additions & 0 deletions framework/source/class/qx/bom/Cookie.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@

/**
* A wrapper for Cookie handling.
*
* Previous versions of qooxoo use `escape()` and `unescape()` functions. Since those functions
* are deprecated, then now qooxdoo use `encodeURIComponent()` and `decodeURIComponent()` functions.
* This may break some cookies.
* There are no issues with special characters like `~!@#$%^&*(){}[]=:/,;?+\'"\\` but some unicode
* characters like `äëíöü` (etc) are encoded different by `escape()` and `encodeURIComponent()`,
* so you must take care of this change if you use unicode characters.
*/
qx.Bootstrap.define("qx.bom.Cookie",
{
Expand Down

0 comments on commit 41cdf39

Please sign in to comment.