Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacOS: sign all bundles, rather than listing them explicitly #706

Merged
merged 2 commits into from
May 2, 2024
Merged

MacOS: sign all bundles, rather than listing them explicitly #706

merged 2 commits into from
May 2, 2024

Conversation

mikeage
Copy link
Member

@mikeage mikeage commented May 2, 2024 •
edited
Loading

PR #573 introduced new bundles, and since they weren't signed, the DMG notarization failed.

@mikeage mikeage added the infrastructure Build or tooling infrastructure label May 2, 2024
@mikeage mikeage changed the title Sign all bundles, including the two added that just broke main MacOS: sign all bundles, rather than listing them explicitly May 2, 2024
@mikeage
Copy link
Member Author

mikeage commented May 2, 2024

Tested at https://github.com/icosa-foundation/open-brush/actions/runs/8929079732/job/24527552154

@mikeage mikeage merged commit 1ef70e5 into main May 2, 2024
42 checks passed
@mikeage mikeage deleted the infra/sign_all_bundles branch May 2, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
infrastructure Build or tooling infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mikeage