added pypi-ci #36
added pypi-ci #36
Conversation
|
I added the tokens, the PR is ready for review. @Nicogene @CarlottaSartore @mfussi66 please give me your pypi handles to be added to the project, thanks! |
Mine is |
Ok, I will add you as soon as the first release exists, otherwise before there is no pypi project to add you to. |
README.md
Outdated
|
|
||
| ```bash | ||
|
|
||
| pip install "urdfModifiers @ git+https://github.com/icub-tech-iit/urdf-modifiers" | ||
| pip install urdfModifiers |
There was a problem hiding this comment.
| pip install urdfModifiers | |
| pip install urdf-modifiers |
There was a problem hiding this comment.
I would also change https://github.com/CarlottaSartore/urdf-modifiers/blob/adding_pypi_ci/setup.cfg#L2 .
There was a problem hiding this comment.
Argh, but the python module name is urdfModifiers .
There was a problem hiding this comment.
To clarify why I do not like urdfModifiers, camel case is not suggested in PEP8 guidelines, see https://peps.python.org/pep-0008/#package-and-module-names, and not so common at all (see https://pypistats.org/top). Anyhow, I don't want to create more friction than necessary, so if you want to go forward with urdfModifiers, feel free to proceed.
There was a problem hiding this comment.
Thinking more about this, I think we should at least call the package name urdf-modifiers . We can always change the module name later from urdfModifiers to urdf-modifiers in a backward compatible way, but changing python package name would be complex.
Mine is |
Mine is |
| author = "TODO" | ||
| author_email = TODO |
There was a problem hiding this comment.
| author = "TODO" | |
| author_email = TODO | |
| author = "Germán Rodriguez, Alexandre Antunes" | |
| author_email = "[email protected]" | |
| mantainer = "Nicolo Genesio, Mattia Fussi" | |
| mantainer_email = "[email protected], [email protected]" |
There was a problem hiding this comment.
cc @Nicogene @mfussi66 please double check, thanks!
fyi @CarlottaSartore
There was a problem hiding this comment.
Ok for mine, I am not sure about the German email :D
There was a problem hiding this comment.
Ok for mine, I am not sure about the German email :D
I got it from LinkedIn.
Co-authored-by: Silvio Traversaro <[email protected]>
|
Thanks @Nicogene ! Can we publish a new release to check if the PyPI upload is working fine? |
|
Unfortunately it failed (cc @traversaro @CarlottaSartore) |
This should address #35
Now on releases, urdf-modifier should be release on pypi