Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove firewall configuration feature #11

Merged
merged 1 commit into from
May 8, 2024

Conversation

mrolli
Copy link
Member

@mrolli mrolli commented Apr 30, 2024

In line with the Ansible team decision that firewall configuration is
not a concern of a general Ansible role, this change now reverts the
firwealld configuration feature again.

Fixes #10

@mrolli mrolli added the enhancement New feature or request label Apr 30, 2024
@mrolli mrolli self-assigned this Apr 30, 2024
@mrolli mrolli linked an issue Apr 30, 2024 that may be closed by this pull request
3 tasks
@mrolli mrolli requested review from a team, IDRole and msalzmann and removed request for a team and IDRole April 30, 2024 03:49
@mrolli mrolli force-pushed the 10-remove-firewalld-configuration branch from f55f1e4 to f69bffc Compare May 3, 2024 06:40
In line with the Ansible team decision that firewall configuration is
not a concern of a general Ansible role, this change now reverts the
firwealld configuration feature again.

Fixes #10
@mrolli mrolli force-pushed the 10-remove-firewalld-configuration branch from f69bffc to 50ceec5 Compare May 3, 2024 09:41
Copy link
Contributor

@grvlbit grvlbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I want this PR to be merged and this is a straightforward change, I'll review now. Looks good. Thanks!

@mrolli mrolli merged commit 5999cc5 into main May 8, 2024
7 checks passed
@mrolli mrolli deleted the 10-remove-firewalld-configuration branch May 8, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove firewalld configuration
2 participants