-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug that was comparing string to listNodes #561
Merged
MicahGale
merged 11 commits into
develop
from
552-listnode-comparison-is-blocking-contains-for-listnode
Oct 7, 2024
Merged
Fixed bug that was comparing string to listNodes #561
MicahGale
merged 11 commits into
develop
from
552-listnode-comparison-is-blocking-contains-for-listnode
Oct 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicahGale
added
the
bugs
A deviation from expected behavior that does not reach the level of being reportable as an "Error".
label
Oct 1, 2024
MicahGale
changed the title
552 listnode comparison is blocking contains for listnode
Fixed bug that was comparing string to listNodes
Oct 1, 2024
MicahGale
force-pushed
the
552-listnode-comparison-is-blocking-contains-for-listnode
branch
from
October 1, 2024 14:09
874af41
to
a129b17
Compare
tjlaboss
approved these changes
Oct 7, 2024
MicahGale
deleted the
552-listnode-comparison-is-blocking-contains-for-listnode
branch
October 7, 2024 17:37
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugs
A deviation from expected behavior that does not reach the level of being reportable as an "Error".
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This bug is caused by a shortcut being in a fill. This is because it tries
"(" in list_node.nodes'. Due to the shortcut there is a
ListNode(shortcut) in this list which requires a
eq` test.This was fixed by
Fixes #552
Checklist