Fix unit scaling factors in InterfaceSorption and add transient tests
#195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- clean up existing tests - create new input file for transient - create new tests for transient - create new gold files
|
Job Documentation, step Sync to remote on 04cbb31 wanted to post the following: View the site here This comment will be updated on new commits. |
… wrong Creating a related issue (Ref. #196)
|
Recover does not work properly with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the
InterfaceSorptioncapability was not explicitly tested in transient conditions, and that the unit scaling system was deficient.I fixed all that and added new tests. Convergence and accuracy are improved. I also added some clarification in the documentation.
(Close. #50)
(Close. #156)