-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reporter for nodal variable values at the elements located by nearestElemsToLine #109
base: devel
Are you sure you want to change the base?
Conversation
de68534
to
8a0a68e
Compare
…ed by the nearestElemsToLine. Also renamed the variable used to for filtering elements and updated tests. closes idaholab#108
8a0a68e
to
3e7a13d
Compare
{ | ||
//_value should be zero on every proc so this will just communicate it. | ||
for (size_t i = 0; i < _eid.size(); ++i) | ||
gatherSum(_value[i]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dschwen is this a good way to get the value to all the processors?
n++; | ||
} | ||
if (n > 0) | ||
value /= (Real)n; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C style cast
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Real(n)
or static_cast<Real>(n)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but neither is needed here, just do value /= n;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dschwen would you look at this pr again. I didn't do averaging over gauss points because reporters don't have a base class that derives off the elem or nodal userobjects.
65523a0
to
dd1d4b2
Compare
…ass was changed because this will now work for element variables
dd1d4b2
to
d2f302c
Compare
@lynnmunday -- is this something others need? If no, it can wait until 10/1 to fix |
@rpodgorney No else needs this right now. I'll fix it in a few weeks. |
@lynnmunday what's the status of this PR? Are we waiting until next FY to finalize? |
Also renamed the variable used to for filtering elements and updated tests. closes #108