-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All pending dacite
PRs - merged and released as dacite2
#1
Conversation
e3dc5dc
to
76b7df1
Compare
Finally all the tests pass. |
76ffc0e
to
04a6e4c
Compare
@idanmiara While I'm sympathetic to this initiative, I'm not sure I can add much value in reviewing all these PRs as one in bulk. That should really happen one by one in my opinion. I do stand by the PRs I've opened myself, and I still think they're valuable contributions. If you want help in reviewing individual PRs, I could possibly commit some of my time to that. I do think it's unfortunate that it's come to this point with the original project, but at some point things just have to move on. Ideally we could work out a way to move forward with the blessing of @konradhalas to avoid having a split community. |
… dict assigned with None value
Reproducible build fails if the file is encoded differently depending on the current locale settings when reading README.md.
test for type_hook with initVar added
added tests for type hinting with generic collections
- Remove unused type: ignore. - Remove asterisk import and add `__all__` with all exported names, to pass with the `no_explicit_reexport` mypy flag. - Add various mypy config for developer ergonomics (prettier errors, printing error codes, warning about unused config, ignores and casts etc). Kept `warn_return_any = False` in `dacite.types` for now since there would have to be a lot of ignores/casts otherwise.
Also add a test to help ensure that type_hooks continues to work with a very general Mapping implementation.
allow `is_instance` checks for arbitrary generic types add test for `npt.NDArray` handling
mark 2 tests with `init_var_type_support`
Hi @antonagestam
Good point. I've rebased all everything and squashed each PR by itself, and solved all conflicts.
I've decided to publish in pypi as |
dacite
PRs - merged and released as dacite2
5e60203
to
bada8b1
Compare
Hi,
Edit: I pushed this to pypi as
dacite2==2.0.0
, feel free to test.https://pypi.org/project/dacite2/
@konradhalas - I made this fork as I wanted to merge all the pending PRs.
Since I can't push to pypi with the name
dacite
I renamed the pypi package todacite2
(module name stilldacite
).If you want to take this from here and merge the PRs to
dacite
please do :)I've tried to rebase all the open PRs one by one.
I tied to handle the conflicts as best as I could.
But I didn't dive deeply into each and every PR, so there might be bugs.
Feel free to comment!
@thincal @das-intensity @radiosilence @antonagestam @michalchrobok @SzymonSwic @BurningKarl @daiwt @tgpfeiffer @yerihyo @trojkat @sinback @vvidic @channelcat
konradhalas#199
konradhalas#196
konradhalas#191
konradhalas#184
konradhalas#175
konradhalas#172
konradhalas#164
konradhalas#159
konradhalas#156
konradhalas#128
konradhalas#122
konradhalas#120
konradhalas#86
konradhalas#83
konradhalas#76