Issue 13 #14
Merged
Issue 13 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* commit '822de91d69cfcc6b6446b63db0af6833d56196aa': molecule.yml edited online with Bitbucket LICENSE edited online with Bitbucket Some fixes Minor updates Initial version
Update README.md
Create .travis.yml
Added tests for entire yml put on consul keystore Add ansible-lint and improve yamllint Improve task to avoid unnecessary skipped or loops Update test-requirements and deleted 2.7 python Add test for debian buster environment Update molecule tests and test files Rename from consul_keystore-role to consul_keystore_role as ansible recommendations Replace module consul_keystore committed in repo in favour of consul_kv official module
adrian-arapiles
requested review from
ultraheroe,
jperera,
dortegau,
frantsao,
jmonterrubio,
sorobon,
vicsufer,
marcelogalmor,
blalop,
xtianae7,
caldito,
emepege and
a team
blalop
approved these changes
Aug 30, 2021
vicsufer
approved these changes
Aug 30, 2021
xtianae7
approved these changes
Sep 1, 2021
caldito
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Support for put entire yml files to consul keystore
Added tests for entire yml put on consul keystore
Add ansible-lint and improve yamllint
Improve task to avoid unnecessary skipped or loops
Update test-requirements and deleted 2.7 python
Add test for debian buster environment
Update molecule tests and test files
Rename from consul_keystore-role to consul_keystore_role as ansible recommendations
Replace module consul_keystore committed in repo in favour of consul_kv official module
Benefits
Updated dependencies and code.
New feature #13
Possible Drawbacks
Some refactor so implies new major.
Applicable Issues
#13