Nullifier & ProofType changes. Archive old circuits. Optimizations #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
OBrezhniev
commented
Oct 12, 2023
•
OBrezhniev
commented
- Fix unit tests
- Create unit test for updated nullifier
…mplates. Economy: 1304 constraints for V3 circuit. Per template constraints measurements.
…y: 11378 constraints
… that switches between issuerAuthState and issuerAuthState depending on proofType, so that only one value needs to be checked outside the circuit. Added missing isRevocationChecked signal output to testvector gen. Minor testvectorgen code reorg.
Economy: -1843 constraints for OffChain (now 56955), and -1075 for OnChain (now 108519)
…s` option in tests because it has no effect.
…archive # Conflicts: # archive_circuits_V2/test/onchain/credentialAtomicQueryMTPOnChain.test.ts
…zation-after-archive # Conflicts: # circuits/offchain/credentialAtomicQueryMTPOffChain.circom # circuits/offchain/credentialAtomicQuerySigOffChain.circom # circuits/onchain/credentialAtomicQueryMTPOnChain.circom # circuits/onchain/credentialAtomicQuerySigOnChain.circom
…emove fieldValue from nullifier calculation
…testvectorgen to use v2 core & schema processor. Added cache or JSON-LD schemas. Changed generated did to did:iden:polygon:mumbai
[WIP] Extract nullifier, change proofType values
OBrezhniev
changed the title
OBrezhniev
changed the title
Fix claim utils tests
vmidyllic
reviewed
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.