Circuits V3: init commit. Update package deps. Replace test( ti it( #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/circuits/atomicV3.ts
Outdated
| const isValidMTPType = | ||
| query.proofType === ProofType.Iden3SparseMerkleTreeProof && proofType === 2; | ||
|
|
||
| if (!isValidSigType || !isValidMTPType) { |
There was a problem hiding this comment.
it will always fail (if isValidMTPType is true, isValidMTPType always would be false)
There was a problem hiding this comment.
we need AND here I guess (as it was before)
vmidyllic
reviewed
Jan 18, 2024
| const isValidMTPType = | ||
| query.proofType === ProofType.Iden3SparseMerkleTreeProof && proofType === 2; | ||
|
|
||
| if (!isValidSigType && !isValidMTPType) { |
There was a problem hiding this comment.
this is wrong check.
if proofType == '' , then signal can be 1 or 2.
see https://github.com/iden3/go-iden3-auth/blob/8e8050511faf8384126ae6bb44641a5611b8e888/pubsignals/atomicV3.go#L57
| throw new Error(`Nullifier id is generated but wasn't requested`); | ||
| } | ||
|
|
||
| if (typeof query.groupId === 'undefined' && this.pubSignals.linkID !== 0n) { |
There was a problem hiding this comment.
we also need to check if groupId is provide linkNonce must not be zero
| @@ -19,7 +18,7 @@ export class AuthPubSignalsV2 extends IDOwnershipPubSignals implements PubSignal | |||
| this.challenge = this.pubSignals.challenge; | |||
| } | |||
|
|
|||
| async verifyQuery(_query: Query): Promise<void> { | |||
| async verifyQuery(): Promise<void> { | |||
There was a problem hiding this comment.
won't it throw error if we try to pass here query in auth.ts checks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.