Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.9 support #14

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Drop Python 3.9 support #14

wants to merge 12 commits into from

Conversation

eginhard
Copy link
Member

@eginhard eginhard commented Nov 29, 2024

  • Same as for Coqpit. There are already just very few Python 3.9 installs for coqui-tts and dropping it simplifies the type hints here a lot.
  • Add type hints for the main public interface
  • Add a consistency check for the optimizer attributes in the config
  • Use Pytorch @inference_mode() decorator instead of changing global state with torch.set_grad_enabled(False)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant