Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use released eventsource #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tricknotes
Copy link
Contributor

EventSource/eventsource#61 is merged and released as a new version of eventsource.

EventSource/eventsource#61 is merged and
released as a new version of eventsource.
@ursm
Copy link
Member

ursm commented May 31, 2017

It is wonderful, thank you. However, there is one point to worry about. eventsource has changed the reconnection behavior with the following commits.

This may affect hubot-idobata error handling.

stream.on 'error', (e) =>

Can you write a regression test for this?

@tricknotes
Copy link
Contributor Author

Thanks for your review, @ursm.
Oops, I'm ashamed of my oversight... 😢

Yes, of course! I'll add it at the end of this week 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants