Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tiktok link sanitization #429

Open
wants to merge 19 commits into
base: dev
Choose a base branch
from
Open

feat: add tiktok link sanitization #429

wants to merge 19 commits into from

Conversation

namemcguffin
Copy link
Contributor

@namemcguffin namemcguffin commented May 31, 2021 •
edited
Loading

adds a listener that sanitizes tiktok links with trackers

Description

  • added ./cogs/sanitizer.py and made changes to Main.py accordingly
  • added related configuration options to ./config/config.ini

Motivation and Context

tiktok share links contain tracking information that is very hard to redact and can sometimes even contain personal information such as a user's full name

How Has This Been Tested?

tested in the idoneam discord

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

davidlougheed
davidlougheed requested changes Jul 25, 2021
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remov

README.md Outdated Show resolved Hide resolved
cogs/sanitizer.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@namemcguffin namemcguffin changed the title add tiktok link sanitation add tiktok link sanitization Jul 25, 2021
@namemcguffin namemcguffin marked this pull request as draft July 25, 2021 17:06
@namemcguffin namemcguffin marked this pull request as ready for review August 6, 2021 20:12
@namemcguffin
change: bot no longer DMs user, instead warning message is sent in ch…
169d92f 
…annel and pings user.

change: expanded regex to include optional final `/`.
@namemcguffin namemcguffin changed the title add tiktok link sanitization feat: add tiktok link sanitization Aug 18, 2021
@namemcguffin namemcguffin added the enhancement New feature or request label Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlougheed davidlougheed davidlougheed requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namemcguffin @davidlougheed