Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] ISSUE-11477 - fixed Swagger response for searchCriteria #1

Open
wants to merge 694 commits into
base: 2.3-develop
Choose a base branch
from

Conversation

idziakjakub
Copy link
Owner

Original Pull Request

magento#15322
Added zero index to array signifier in searchCriteria parameters builder

Description

This fix allows to generate correct response when user want to test method with some search criteria parameters in Swagger.

Fixed Issues (if relevant)

  1. Magento REST API Schema (Swagger) is not compatible with Search Criteria magento/magento2#11477: Magento REST API Schema (Swagger) is not compatible with Search Criteria

Manual testing scenarios

  1. Open Swagger
  2. In method "catalogProductRepositoryV1" fill in "Parameters" tab values for searchCriteria which use "filterGroups" key
  3. Click "Try it out!"
  4. Check if Response Code is 200

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

ameysar and others added 30 commits May 30, 2018 11:36
 - Merge Pull Request magento#15498 from lfluvisotto/magento2:2.3-develop-missing-phpdoc-comment
 - Merged commits:
   1. 949de44
   2. c78fbc0
   3. 2a20abd
   4. d6aabc3
…e order button magento#15577

 - Merge Pull Request magento#15577 from osrecio/magento2:2.3-develop-PR-port-15331
 - Merged commits:
   1. 751c3e6
   2. fb0f192
… #ToDo UI magento#15537

 - Merge Pull Request magento#15537 from vgelani/magento2:2.3-develop-PR-port-15421
 - Merged commits:
   1. 2dabd7d
Fixed issues:
 - MAGETWO-91934: Unlock Locales Editing when SCD on Demand Mode is Enabled
Fixes Javascript error in dropdowns.js by properly initializing the el variable. options.autoclose can now be set to false
…agento#15607

 - Merge Pull Request magento#15607 from dmytro-ch/magento2:2.3-develop-PR-port-15499
 - Merged commits:
   1. 1e2019c
- update static test to skip xsd validation for Module/Test/ folder
magento-engcom-team and others added 30 commits June 5, 2018 08:58
 - Merge Pull Request magento#15695 from dverkade/magento2:2.3-Fix-typos
 - Merged commits:
   1. f0eb540
magento#15853

 - Merge Pull Request magento#15853 from rogyar/magento2:2.3-wishlist-return-fix
 - Merged commits:
   1. ea8c241
[arcticfoxes] MAGETWO-91434: Default option for 'Status' attribute not being set
…6-Custom-Options-are-corruputed

# Conflicts:
#	dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Section/AdminProductFormSection.xml
… different website

- restoring productStatus identifier
…436-Custom-Options-are-corruputed

[honey] MAGETWO-91436: Custom Options are corruputed when saving product to a different website
Accepted Public Pull Requests:
 - magento#15853: Fixed return type hinting in DocBlocks for Wishlist module (by @rogyar)
 - magento#15695: Fixed a couple of typos  (by @dverkade)
 - magento#15833: [Forwardport] Format the javascript code magento#10 (by @chirag-wagento)
 - magento#15755: [Forwardport] Error 500 in Module Manager (by @vijay-wagento)
 - magento#15794: [Forwardport] [Resolved : Styling <select> by changing less variables in Luma theme� (by @hitesh-wagento)
 - magento#15809: [Forwardport] fix: support multiple minisearch widget instances (by @DanielRuf)
 - magento#15558: Fixes in catalog component blocks [2.3-develop] (by @mhauri)
 - magento#15572: [Forwardport] Docblock typo fixes (by @rogyar)
 - magento#15748: [Forwardport] Prevent multiple add-to-cart initializations in case of ajax loaded product listing (by @vijay-wagento)
 - magento#15745: [Forwardport] Fix method name (typo) (by @vijay-wagento)
 - magento#15746: [Forwardport] Resolved : UI Component listing action column outside of screen when... (by @vgelani)
 - magento#15692: Fix minor issues in ui export converter classes (by @dmytro-ch)
 - magento#15649: [Forwardport] Fixes in config module (by @mhauri)
 - magento#15540: fix for Wrong price amount on product page magento#11717 (by @HirokazuNishi)


Fixed GitHub Issues:
 - magento#15192: Module Manager module grid is not working Magento 2.2.4 (reported by @jignesh-baldha) has been fixed in magento#15755 by @vijay-wagento in 2.3-develop branch
   Related commits:
     1. 486f7a7
     2. 1b5d1d1

 - magento#15608: Styling <select> by changing less variables in Luma theme doesn't work as expected (reported by @denistrator) has been fixed in magento#15794 by @hitesh-wagento in 2.3-develop branch
   Related commits:
     1. 9fa6425

 - magento#14153: UI Component listing action column outside of screen when too many columns (reported by @milansimek) has been fixed in magento#15746 by @vgelani in 2.3-develop branch
   Related commits:
     1. 365bfb4

 - magento#11717: Wrong price amount on product page (reported by @HirokazuNishi) has been fixed in magento#15540 by @HirokazuNishi in 2.3-develop branch
   Related commits:
     1. cf05a84
     2. 67a2038
[TSG] Upporting for 2.3 (pr21) (2.3.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.