-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusted the Export script #29
Conversation
Codecov Report
@@ Coverage Diff @@
## main #29 +/- ##
=======================================
Coverage 77.47% 77.47%
=======================================
Files 4 4
Lines 111 111
Branches 1 1
=======================================
Hits 86 86
Misses 25 25 Continue to review full report at Codecov.
|
Is this still up 4 review? I thought we discussed that it might not make sense to have it that way? 🤔 |
@johanneshiry Regarding 1: We still need the connected elements for building the grid topology to map the different components to the nodes they are connected to. Regarding 2: I thought we came to the conclusion that it would make sense to go for that approach while developing, as it makes the process of incrementally including new parameters much more seamless. So I think that it still makes sense, but I am happy to discuss it. |
!test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like, that you do not overwhelm the user with documentation. ;-)
THANKS! Finally someone who noticed 😂 |
!test |
1 similar comment
!test |
Resolves #17