Implementing GitHub Actions Pipeline #982
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+13
to
+15
| - 'feature/*' | ||
| - 'hotfix/*' | ||
| - 'release/*' |
There was a problem hiding this comment.
You probably know this, but these have to be adapted to the branch naming scheme that we use
Comment on lines
+18
to
+19
| - main | ||
| - dev |
There was a problem hiding this comment.
Do we still need the pull_request specification, if CI is running on branches already?
| name: CI | ||
|
|
||
| on: | ||
| push: |
There was a problem hiding this comment.
paths-ignore for docs could also be useful? readthedocs has its separate CI
Comment on lines
+48
to
+49
| with: | ||
| gradle-version: "8.10" |
There was a problem hiding this comment.
Seems like you can leave out the specification of the version if the project already configures gradle (which it does).
|
|
||
| - name: Run Tests | ||
| run: | | ||
| ./gradlew --refresh-dependencies spotlessCheck pmdMain pmdTest |
There was a problem hiding this comment.
--refresh-dependencies makes more sense before assemble, I think
| id: sonarqube-quality-gate-check | ||
| uses: sonarsource/sonarqube-quality-gate-action@master | ||
| # Force to fail step after specific time. | ||
| timeout-minutes: 60 |
There was a problem hiding this comment.
This could probably be reduced (but isn't that important)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #939