Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ieee 255 overview #504

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Ieee 255 overview #504

wants to merge 13 commits into from

Conversation

phamalis
Copy link

@phamalis phamalis commented Jun 18, 2023

Overview

  • Resolves 255

  • Created the Overview Section composed of cards that shows total number of

  • items checked out
  • number of participants
  • teams
  • orders
  • broken/lost items
  • For each card there shows a corresponding icon

image-20230520-175802

Unit Tests Created

Steps to QA

@Mustaballer
Copy link
Contributor

Mustaballer commented Jun 26, 2023

Hey @phamalis this looks good, please schedule some time with me this week so we can create/use redux selectors to get the real data.

@Mustaballer
Copy link
Contributor

@phamalis Can you push your latest changes, and address the merge conflicts. What's the latest on this?

…plate into ieee-255-overview

git commit -m 'merge because pycharm asked me to pull before push, new update allows overview section to update with real data'
danielqiuu
danielqiuu previously approved these changes Sep 1, 2023
Copy link
Contributor

@danielqiuu danielqiuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like Alisha has implemented a few selectors (which were outside the scope of this ticket/pr). This page is still missing the selector that fetches the number of broken/lost items. Which should probably be implemented in another ticket (since this one focuses on ui)

@@ -205,4 +205,29 @@ export const adminOrderTotalSelector = createSelector(
(orderItems) => orderItems.reduce((accum) => accum + 1, 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change name of adminOrderTotalSelector to 'adminOrderTotalWithFiltersSelector', or similar.

@@ -205,4 +205,29 @@ export const adminOrderTotalSelector = createSelector(
(orderItems) => orderItems.reduce((accum) => accum + 1, 0)
);

export const adminOrderNewTotalSelector = createSelector(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get rid of 'new' in naming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants