Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add disclaimer banner for unadopted I-Ds and non-IETF RFCs #6786

Merged
merged 21 commits into from
May 23, 2024
Merged

feat: Add disclaimer banner for unadopted I-Ds and non-IETF RFCs #6786

merged 21 commits into from
May 23, 2024

Conversation

rjsparks
Copy link
Member

replaces PR #6589 which was moved to a feature branch

@codecov Codecov
Copy link

codecov bot commented Dec 15, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.80%. Comparing base (187c2c5) to head (3e699df).
Report is 208 commits behind head on main.

❗ Current head 3e699df differs from pull request most recent head 167b5ce

Please upload reports for the commit 167b5ce to get more accurate results.

Files Patch % Lines
ietf/doc/templatetags/ietf_filters.py 94.11% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6786      +/-   ##
==========================================
- Coverage   88.98%   88.80%   -0.19%     
==========================================
  Files         291      284       -7     
  Lines       40717    40378     -339     
==========================================
- Hits        36233    35857     -376     
- Misses       4484     4521      +37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

larseggert and others added 3 commits December 20, 2023 13:17
@larseggert
fix: Wording changes from stream owners
5c2b506
@larseggert
fix: Only insert <wbr> when there isn't a space before or after (#6821)
9f0a97c 
* fix: Only insert <wbr> when there isn't a space before or after.

* Fix @cabo's issue
@rjsparks
Merge pull request #6822 from larseggert/fix-disclaimer-wording
94b405f 
fix: Wording changes from stream owners
@rjsparks
Merge pull request #6838 from ietf-tools/main
8e050ff 
ci: merge main into feat/clarity
@rjsparks
Copy link
Member Author

rjsparks commented Jan 8, 2024

IESG and stream manager approval noted at #6589

@elear
Copy link
Contributor

elear commented Feb 22, 2024

Can someone test against independent submission stream before merging?

@rjsparks
Copy link
Member Author

@elear - this branch is available for everyone to test at dt-clarity.dev.ietf.org.

See, for example,
https://dt-clarity.dev.ietf.org/doc/draft-li-arch-sat/
or
https://dt-clarity.dev.ietf.org/doc/rfc9517/

What else did you intend for "test against"?

@rjsparks rjsparks merged commit 720f31b into main May 23, 2024
7 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
@rjsparks rjsparks deleted the feat/clarity branch August 9, 2024 14:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jennifer-richards jennifer-richards jennifer-richards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rjsparks @elear @jennifer-richards @larseggert