Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: async investigate_fragment task; celery results backend #8428

Merged
merged 9 commits into from
Jan 17, 2025

Conversation

jennifer-richards
Copy link
Member

Moves the investigate_fragment() call out of the view and into a celery task. Updates the view to provide task polling support. Adds JS to start the task, poll for completion, and reload the results.

Adds the django-celery-results package so we can use the Django cache config to store task results. This replaces the unused rpc backend, which was not suitable for async results retrieval. Only stores results for the new task - others remain ignored - and only keeps them for 5 minutes after task completion.

rjsparks
rjsparks previously approved these changes Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.81%. Comparing base (4f53cad) to head (ba7f2d9).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8428   +/-   ##
=======================================
  Coverage   88.81%   88.81%           
=======================================
  Files         312      312           
  Lines       40876    40930   +54     
=======================================
+ Hits        36304    36352   +48     
- Misses       4572     4578    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks merged commit c848a5a into ietf-tools:main Jan 17, 2025
10 checks passed
@jennifer-richards jennifer-richards deleted the async-investigate branch January 17, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants