Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase investigate time; more feedback #8457

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

jennifer-richards
Copy link
Member

Increases the time limit to 10 minutes. The old limit was too short - our first test took a bit less than 4 minutes.

If this time limit is still too short, we should probably rethink the mechanism.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (a4eeae5) to head (bbce1c8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8457   +/-   ##
=======================================
  Coverage   88.80%   88.80%           
=======================================
  Files         312      312           
  Lines       40886    40886           
=======================================
  Hits        36308    36308           
  Misses       4578     4578           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks merged commit 9a72cc0 into ietf-tools:main Jan 22, 2025
10 checks passed
@jennifer-richards jennifer-richards deleted the longer-investigation branch January 22, 2025 17:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants