-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP A_Opus #106
base: master
Are you sure you want to change the base?
WIP A_Opus #106
Conversation
This needs a definition of the Initialization, ping @JeromeMartinez. Here's an example of CodecPrivate in MediaTrace
|
Look like Opus header is not required for decoding, only for metadata (i.e. channel mapping), defaults could be used (gain of 0? pre-skip from Matroska SeekPreRoll element) for other items. |
Back when I added Opus support to mkvmerge I decided to use Xiph's Opus in Matroska mapping. The elements I strongly recommend to make the header mandatory. You could use defaults for the channels, but not for the |
To be clear: |
For the moment, as all other Matroska elements are already in the spec, I see only
to add. Is it correct from your point of view? |
It is, yes. |
partly resolves #100
It setting
or address If the |
Ping to @mbunkus @JeromeMartinez. I'm unsure what the status is here. Should we say that A_Opus infers some additional defaults on other Elements (IMHO codec-specific defaults makes for complex semantics). |
No, we should not say that. Those values are valid for the current edition/version of the Opus specs. But the Matroska specs should not tie themselves to a certain version of a codec spec in such a way. What if Opus v3 decides to use a different pre-roll? We would have to adjust the Matroska specs. If anything, we should say that |
|
||
Codec Name: Opus interactive speech and audio codec | ||
|
||
Description: Opus is designed to handle a wide range of interactive audio applications, including Voice over IP, videoconferencing, in-game chat, and even live, distributed music performances. It scales from low bitrate narrowband speech at 6 kbit/s to very high quality stereo music at 510 kbit/s. Opus uses both Linear Prediction (LP) and the Modified Discrete Cosine Transform (MDCT) to achieve good compression of both speech and music. Opus is defined in [RFC6716](https://tools.ietf.org/html/rfc6716). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description is meant to be about the mapping of the codec to Matroska: what blocks contain, how header fields have to be set (if anything special has to be observed) etc. It's not supposed to be a description of the codec itself. The Matroska specs are not codec specs or their marketing department.
partly resolves
#100