-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add block additional mapping for generic type/value #353
base: master
Are you sure you want to change the base?
Add block additional mapping for generic type/value #353
Conversation
fa0db41
to
2c716ac
Compare
2c716ac
to
3184d65
Compare
3184d65
to
e247a99
Compare
If I understand this PR correctly, there would not be a way to associate more than a single key/value pair with each frame. That I definitely don't like. Additionally we don't have a way of associating a |
In FFmpeg packets can have AV_PKT_DATA_STRINGS_METADATA side data, a list of zero terminated key/value strings. The whole side data is externally framed. Putting such a thing (or something similar; i.e. the strings could be length-prefixed (probably with EBML numbers)) in a Another way to overcome this restriction would be to allow several |
IMO the FFmpeg usage sounds like the "key/value" type is too broad. It's a way to store the data, but it doesn't say what the data correspond to. There might be different systems using the same key. It should be a |
So they are all found in one place in the document.
76565ff
to
9fa9cb2
Compare
Rebased so it can be used. (SMPTE ST 12-1 has been merged) |
9fa9cb2
to
221c7ab
Compare
Rebased on top of #936 to simplify. There is nothing is the spec that says the same There's still the caveat that it's loosely defined and not very useful to interpret. |
Moving this to Matroska v5 as this is not used yet (or in Rawcooked ?). (if it's merged before we finalize the codec document, it's fine). |
This is based upon the timecode branch, but this offers a generic key/value structure for side data. For discussion.