Merge pull request #245 from ifad/chore/use-delegate

Use Rails' delegate
ifad · Oct 19, 2023 · 5aedcdf · 5aedcdf
2 parents fbb16fa + 5a2fae8
commit 5aedcdf
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 16 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
diff --git a/lib/chrono_model/time_machine.rb b/lib/chrono_model/time_machine.rb
@@ -102,9 +102,7 @@ def history?
 
       # Returns an ActiveRecord::Relation on the history of this model as
       # it was +time+ ago.
-      def as_of(time)
-        history.as_of(time)
-      end
+      delegate :as_of, to: :history
 
       def attribute_names_for_history_changes
         @attribute_names_for_history_changes ||= attribute_names -

diff --git a/lib/chrono_model/time_machine/history_model.rb b/lib/chrono_model/time_machine/history_model.rb
@@ -109,9 +109,7 @@ def of(object)
         #
         # As such it is overriden here to return the same contents that
         # the parent would have returned.
-        def sti_name
-          superclass.sti_name
-        end
+        delegate :sti_name, to: :superclass
 
         # For STI to work, the history model needs to have the exact same
         # semantics as the model it inherits from. However given it is
@@ -120,9 +118,7 @@ def sti_name
         # same exact hierarchy location as its parent, thus this is defined in
         # this override.
         #
-        def descends_from_active_record?
-          superclass.descends_from_active_record?
-        end
+        delegate :descends_from_active_record?, to: :superclass
 
         private