Merge pull request #249 from ifad/chore/squish-sql-heredocs

Chore/squish sql heredocs

lib/chrono_model/adapter/ddl.rb

@@ -55,7 +55,7 @@ def chrono_history_table_ddl(table)
         parent = "#{TEMPORAL_SCHEMA}.#{table}"
         p_pkey = primary_key(parent)
 
-        execute <<-SQL
+        execute <<-SQL.squish
             CREATE TABLE #{table} (
               hid         BIGSERIAL PRIMARY KEY,
               validity    tsrange NOT NULL,
@@ -82,7 +82,7 @@ def remove_history_validity_constraint(table, options = {})
       # allow setting the PK to a specific value (think migration scenario).
       #
       def chrono_create_INSERT_trigger(table, pk, current, history, fields, values)
-        execute <<-SQL.strip_heredoc
+        execute <<-SQL.strip_heredoc # rubocop:disable Rails/SquishedSQLHeredocs
             CREATE OR REPLACE FUNCTION chronomodel_#{table}_insert() RETURNS TRIGGER AS $$
                 BEGIN
                     #{insert_sequence_sql(pk, current)} INTO #{current} ( #{pk}, #{fields} )
@@ -135,7 +135,7 @@ def chrono_create_UPDATE_trigger(table, pk, current, history, fields, values, op
 
         journal &= columns
 
-        execute <<-SQL.strip_heredoc
+        execute <<-SQL.strip_heredoc # rubocop:disable Rails/SquishedSQLHeredocs
             CREATE OR REPLACE FUNCTION chronomodel_#{table}_update() RETURNS TRIGGER AS $$
                 DECLARE _now timestamp;
                 DECLARE _hid integer;
@@ -189,7 +189,7 @@ def chrono_create_UPDATE_trigger(table, pk, current, history, fields, values, op
       # DELETEd in the same transaction.
       #
       def chrono_create_DELETE_trigger(table, pk, current, history)
-        execute <<-SQL.strip_heredoc
+        execute <<-SQL.strip_heredoc # rubocop:disable Rails/SquishedSQLHeredocs
             CREATE OR REPLACE FUNCTION chronomodel_#{table}_delete() RETURNS TRIGGER AS $$
                 DECLARE _now timestamp;
                 BEGIN
@@ -226,7 +226,7 @@ def insert_sequence_sql(pk, current)
         seq = pk_and_sequence_for(current)
         return 'INSERT' if seq.blank?
 
-        <<-SQL.strip
+        <<-SQL.strip # rubocop:disable Rails/SquishedSQLHeredocs
                     IF NEW.#{pk} IS NULL THEN
                         NEW.#{pk} := nextval('#{seq.last}');
                     END IF;

lib/chrono_model/adapter/indexes.rb

@@ -24,7 +24,7 @@ def add_temporal_indexes(table, range, options = {})
           temporal_index_names(table, range, options)
 
         chrono_alter_index(table, options) do
-          execute <<-SQL
+          execute <<-SQL.squish
             CREATE INDEX #{range_idx} ON #{table} USING gist ( #{range} )
           SQL
 
@@ -53,7 +53,7 @@ def add_timeline_consistency_constraint(table, range, options = {})
         id   = options[:id] || primary_key(table)
 
         chrono_alter_constraint(table, options) do
-          execute <<-SQL
+          execute <<-SQL.squish
             ALTER TABLE #{table} ADD CONSTRAINT #{name}
               EXCLUDE USING gist ( #{id} WITH =, #{range} WITH && )
           SQL
@@ -64,7 +64,7 @@ def remove_timeline_consistency_constraint(table, options = {})
         name = timeline_consistency_constraint_name(table)
 
         chrono_alter_constraint(table, options) do
-          execute <<-SQL
+          execute <<-SQL.squish
             ALTER TABLE #{table} DROP CONSTRAINT #{name}
           SQL
         end

lib/chrono_model/adapter/upgrade.rb

@@ -81,7 +81,7 @@ def chrono_upgrade_from_postgres_v90(table_name)
         p_pkey = primary_key(table_name)
 
         execute "ALTER TABLE #{history_table} ADD COLUMN validity tsrange;"
-        execute <<-SQL
+        execute <<-SQL.squish
             UPDATE #{history_table} SET validity = tsrange(valid_from,
                 CASE WHEN extract(year from valid_to) = 9999 THEN NULL
                      ELSE valid_to