Use Active Support lazy load hooks #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
force-pushed
the
bugfix/231-fix-preload-of-patches
branch
2 times, most recently
from
3898582
to
fd6272d
Compare
tagliala
force-pushed
the
bugfix/231-fix-preload-of-patches
branch
5 times, most recently
from
928d8a5
to
0237900
Compare
tagliala
force-pushed
the
bugfix/231-fix-preload-of-patches
branch
from
0237900
to
b4f097e
Compare
tagliala
changed the title
tagliala
force-pushed
the
bugfix/231-fix-preload-of-patches
branch
6 times, most recently
from
c4611b7
to
7676fda
Compare
tagliala
force-pushed
the
bugfix/231-fix-preload-of-patches
branch
from
7676fda
to
ae1d9b7
Compare
tagliala
force-pushed
the
bugfix/231-fix-preload-of-patches
branch
3 times, most recently
from
fd546d5
to
78bc0cd
Compare
Extend `ActiveRecord::Base` functionality only after `ActiveRecord` has been fully loaded. Also: - Require Railtie as suggested by APIs - Patch DBConsole only if needed - Move application configuration check in an after initialize lazy load hook to be sure that `Rails.application` is available at the moment of the check Ref: - thoughtbot/factory_bot_rails#426 - https://edgeapi.rubyonrails.org/classes/Rails/Railtie.html#class-Rails::Railtie-label-Creating+a+Railtie Close #231
tagliala
force-pushed
the
bugfix/231-fix-preload-of-patches
branch
from
78bc0cd
to
869454a
Compare
tagliala
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend
ActiveRecord::Basefunctionality only afterActiveRecordhasbeen fully loaded.
Also:
to be sure that
Rails.applicationis available at the moment of the checkRef:
Close #231
Todo:
Rake tasks not supported by 'chronomodel' adapter)