Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wasm): move wasm apps from cobra commands to default cmds #113

Merged
merged 12 commits into from
Jul 17, 2024

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Jun 26, 2024

No description provided.

@Pantani
Copy link
Collaborator Author

Pantani commented Jun 26, 2024

waiting for ignite/cli#4212 merge

@Pantani Pantani marked this pull request as ready for review July 8, 2024 17:18
julienrbrt
julienrbrt previously approved these changes Jul 9, 2024
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but some tests are failing and maybe let's add a changelog?

@Pantani Pantani requested a review from julienrbrt July 9, 2024 23:16
@Pantani Pantani force-pushed the feat/wasm-cobra-ext-cmd branch from 2f9b03e to 8048da9 Compare July 10, 2024 23:50
@Pantani Pantani requested a review from julienrbrt July 16, 2024 10:57
julienrbrt
julienrbrt previously approved these changes Jul 17, 2024
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK! (but integration tests are failing)

@Pantani Pantani requested a review from julienrbrt July 17, 2024 20:36
@julienrbrt julienrbrt merged commit 970e074 into main Jul 17, 2024
27 checks passed
@julienrbrt julienrbrt deleted the feat/wasm-cobra-ext-cmd branch July 17, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants