Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump go #127

Closed
wants to merge 1 commit into from
Closed

bump go #127

wants to merge 1 commit into from

Conversation

faddat
Copy link

@faddat faddat commented Aug 25, 2024

No description provided.

julienrbrt
julienrbrt reviewed Aug 25, 2024
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets verify is an app then works with v28 (1.21) and v29 (1.23).
If not let's be conservative qua go version for apps for greater compatibility.

@Pantani
Copy link
Collaborator

Pantani commented Aug 27, 2024

any particular reason for bump go?

@julienrbrt
Copy link
Member

any particular reason for bump go?

IMHO, not really here, especially because we want app to work across Ignite versions.
For ignite cli it makes total sense however.

@julienrbrt julienrbrt closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt left review comments

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

Assignees

@faddat faddat

Labels
app:wasm ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faddat @Pantani @julienrbrt