feat: generate a default mnemonic for chains without keys #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pantani
requested review from
ilgooz,
jeronimoalbi,
julienrbrt and
Ehsan-saradar
as code owners
added 18 commits
December 12, 2023 21:01
# Conflicts: # explorer/main.go # explorer/pkg/gex/gex.go # go.work.sum # hermes/cmd/hermes_configure.go # hermes/go.mod # hermes/main.go # hermes/pkg/hermes/config.go # hermes/pkg/hermes/hermes.go
# Conflicts: # explorer/go.sum # hermes/go.mod # integration/go.sum
# Conflicts: # hermes/README.md
Ehsan-saradar
approved these changes
Dec 13, 2023
added 2 commits
December 16, 2023 00:43
added 2 commits
December 21, 2023 15:04
# Conflicts: # explorer/go.mod # explorer/go.sum # go.work.sum # hermes/go.mod # hermes/go.sum # integration/go.mod # integration/go.sum
…monic # Conflicts: # explorer/go.mod # explorer/go.sum # hermes/go.mod # hermes/go.sum # integration/go.mod # integration/go.sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #8
Description
Generate mnemonics for new wallets if they do not exist, and the user does not provide them. This PR also adds the
--generate-walletsflag to generate a wallet automatically if it does not exist.Other improvements:
_instead-;--jsonflag to Hermes commands so we can parse the result;--generate-configflag to always create a new config file;stdinto Hermes cmd;