refactor: remove Cobra dependency from explorer app #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeronimoalbi
requested review from
ilgooz,
Pantani,
julienrbrt and
Ehsan-saradar
as code owners
|
The PR is just a proposal on how to write Ignite apps favoring the usage of the manifest instead of Cobra, so we can close it if we don't want to move forward with it. Favoring the manifest might bring up extra requirements that we could implement to improve the app developer experience. |
jeronimoalbi
deleted the
refactor/remove-explorer-app-cobra-dependency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the explorer app to remove Cobra from dependencies and favor the usage of Ignite's App manifest