Skip to content

Commit

Permalink
refactor!: promote codespace instead of gitpod (#4533)
Browse files Browse the repository at this point in the history
* refactor!: promote codespace instead of gitpod

* cl

* revert
  • Loading branch information
julienrbrt authored Feb 23, 2025
1 parent 4e78f8e commit 63b69a7
Show file tree
Hide file tree
Showing 13 changed files with 14 additions and 200 deletions.
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/release-tracker.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ versions of cli to guarantee that no regression is introduced -->
- [ ] Update [`changelog.md`](https://github.com/ignite/cli/blob/main/changelog.md)
- [ ] Update [`readme.md](https://github.com/ignite/cli/blob/main/readme.md):
- [ ] Version matrix.
- [ ] Link to Gitpod with a URL to the newly released stable version.
- [ ] Update docs site:
- [ ] Add new release tag to [`docs/versioned_docs`](https://github.com/ignite/cli/tree/main/docs/versioned_docs).
- [ ] After changes to docs site are deployed, check [docs.ignite.com/](https://docs.ignite.com/) is updated.
Expand Down
14 changes: 0 additions & 14 deletions .gitpod.Dockerfile

This file was deleted.

56 changes: 0 additions & 56 deletions .gitpod.yml

This file was deleted.

75 changes: 0 additions & 75 deletions .gitpod/readme.md

This file was deleted.

1 change: 1 addition & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
- [#4361](https://github.com/ignite/cli/pull/4361) Remove unused `KeyPrefix` method
- [#4384](https://github.com/ignite/cli/pull/4384) Compare genesis params into chain genesis tests
- [#4463](https://github.com/ignite/cli/pull/4463) Run `chain simulation` with any simulation test case
- [#4533](https://github.com/ignite/cli/pull/4533) Promote GitHub codespace instead of Gitpod

### Fixes

Expand Down
3 changes: 1 addition & 2 deletions docs/docs/01-welcome/02-install.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ description: Steps to install Ignite CLI on your local computer.

# Install Ignite CLI

You can run [Ignite CLI](https://github.com/ignite/cli) in a web-based Gitpod IDE or you can install Ignite CLI on your
local computer.
You can run [Ignite CLI](https://github.com/ignite/cli) in a web-based IDE or you can install Ignite CLI on your local computer.

## Prerequisites

Expand Down
5 changes: 0 additions & 5 deletions ignite/cmd/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import (
uilog "github.com/ignite/cli/v29/ignite/pkg/cliui/log"
"github.com/ignite/cli/v29/ignite/pkg/dircache"
"github.com/ignite/cli/v29/ignite/pkg/errors"
"github.com/ignite/cli/v29/ignite/pkg/gitpod"
"github.com/ignite/cli/v29/ignite/pkg/goenv"
"github.com/ignite/cli/v29/ignite/pkg/gomodulepath"
"github.com/ignite/cli/v29/ignite/version"
Expand Down Expand Up @@ -259,10 +258,6 @@ func deprecated() []*cobra.Command {
}

func checkNewVersion(cmd *cobra.Command) {
if gitpod.IsOnGitpod() {
return
}

ctx, cancel := context.WithTimeout(cmd.Context(), checkVersionTimeout)
defer cancel()

Expand Down
2 changes: 0 additions & 2 deletions ignite/internal/analytics/analytics.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import (
"github.com/spf13/cobra"

"github.com/ignite/cli/v29/ignite/config"
"github.com/ignite/cli/v29/ignite/pkg/gitpod"
"github.com/ignite/cli/v29/ignite/pkg/matomo"
"github.com/ignite/cli/v29/ignite/pkg/randstr"
"github.com/ignite/cli/v29/ignite/pkg/sentry"
Expand Down Expand Up @@ -89,7 +88,6 @@ func SendMetric(wg *sync.WaitGroup, cmd *cobra.Command) {
Uname: versionInfo.Uname,
CWD: versionInfo.CWD,
BuildFromSource: versionInfo.BuildFromSource,
IsGitPod: gitpod.IsOnGitpod(),
IsCI: getIsCI(),
}

Expand Down
2 changes: 1 addition & 1 deletion ignite/pkg/cosmosfaucet/try_retrieve.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ func guessFaucetURLs(rpcAddress string) ([]*url.URL, error) {
}{
{"4500", "", "."},
{"", "faucet", "."},
{"", "4500", "-"}, // Gitpod uses port number as sub domain name.
{"", "4500", "-"},
}

// creating guesses addresses by basing RPC address.
Expand Down
25 changes: 0 additions & 25 deletions ignite/pkg/gitpod/gitpod.go

This file was deleted.

6 changes: 2 additions & 4 deletions ignite/pkg/matomo/matomo.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ type (
// 1 = internal ON not supported at present | 0 = internal OFF.
Dimension2 uint `url:"dimension2"`

// Dimension3 is gitpod (0 or 1).
// 1 = isGitpod ON | 0 = isGitpod OFF.
// Dimension3 is deprecated.
// Should always be 0.
Dimension3 uint `url:"dimension3"`

// Dimension4 ignite version
Expand Down Expand Up @@ -116,7 +116,6 @@ type (
CWD string
ScaffoldType string
BuildFromSource bool
IsGitPod bool
IsCI bool
}
)
Expand Down Expand Up @@ -221,7 +220,6 @@ func (c Client) SendMetric(sessionID string, metric Metric) error {
Second: now.Second(),
Dimension1: 0,
Dimension2: formatBool(metric.IsCI),
Dimension3: formatBool(metric.IsGitPod),
Dimension4: metric.Version,
Dimension6: metric.ConfigVersion,
Dimension7: metric.Cmd,
Expand Down
6 changes: 0 additions & 6 deletions ignite/version/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"path"
"runtime"
"runtime/debug"
"strconv"
"strings"
"text/tabwriter"

Expand All @@ -21,7 +20,6 @@ import (
"github.com/ignite/cli/v29/ignite/pkg/cosmosbuf"
"github.com/ignite/cli/v29/ignite/pkg/cosmosver"
"github.com/ignite/cli/v29/ignite/pkg/errors"
"github.com/ignite/cli/v29/ignite/pkg/gitpod"
"github.com/ignite/cli/v29/ignite/pkg/xexec"
)

Expand Down Expand Up @@ -49,7 +47,6 @@ type Info struct {
Arch string
Uname string
CWD string
IsGitpod bool
BuildFromSource bool
}

Expand Down Expand Up @@ -163,8 +160,6 @@ func Long(ctx context.Context) (string, error) {
write("Your cwd", info.CWD)
}

write("Is on Gitpod", strconv.FormatBool(info.IsGitpod))

if err := w.Flush(); err != nil {
return "", err
}
Expand Down Expand Up @@ -239,7 +234,6 @@ func GetInfo(ctx context.Context) (Info, error) {
info.OS = runtime.GOOS
info.Arch = runtime.GOARCH
info.GoVersion = strings.TrimSpace(goVersionBuf.String())
info.IsGitpod = gitpod.IsOnGitpod()
info.BuildFromSource = fromSource()

if cwd, err := os.Getwd(); err == nil {
Expand Down
18 changes: 9 additions & 9 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,20 +93,20 @@ The instructions for installing Ignite CLI manually and configuring your system
<details>
<summary>View development setup instructions</summary>

#### Supported Operating Systems:
#### Supported Operating Systems

- GNU/Linux
- macOS

#### Install Go:
#### Install Go

1. Install the latest version of Go.
2. Download the release suitable for your system.
3. Follow the installation instructions.

**Note:** We recommend not using `brew` to install Go.

#### Add the Go bin Directory to Your PATH:
#### Add the Go bin Directory to Your PATH

1. Edit your `~/.bashrc` file and add the following line:

Expand All @@ -120,7 +120,7 @@ The instructions for installing Ignite CLI manually and configuring your system
source ~/.bashrc
```

#### Remove Existing Ignite CLI Installations:
#### Remove Existing Ignite CLI Installations

1. Remove the Ignite CLI binary:

Expand All @@ -132,13 +132,13 @@ The instructions for installing Ignite CLI manually and configuring your system

2. Repeat the step until all Ignite CLI installations are removed.

#### Install Ignite CLI:
#### Install Ignite CLI

```sh
curl https://get.ignite.com/cli! | bash
```

#### Clone the Ignite CLI Repo:
#### Clone the Ignite CLI Repo

1. Clone the repository:

Expand All @@ -152,21 +152,21 @@ curl https://get.ignite.com/cli! | bash
cd cli
```

#### Run make install:
#### Run make install

```sh
make install
```

#### Verify Your Ignite CLI Version:
#### Verify Your Ignite CLI Version

```sh
ignite version
```

</details>

Alternatively, you can open Ignite CLI directly in your web browser via [Gitpod](https://gitpod.io/#https://github.com/ignite/cli).
Alternatively, you can open Ignite CLI directly in your web browser via [GitHub Codespaces](https://github.com/features/codespaces): [Open in GitHub Codespaces](https://github.dev/ignite/cli).

## Documentation

Expand Down

0 comments on commit 63b69a7

Please sign in to comment.