Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix gentx parser into the cosmosutil package (backport #4402) #4405

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 11, 2024

Fix gentx parser into the cosmosutil package because the use of Delegator Address in MsgCreateValidator is deprecated

https://github.com/cosmos/cosmos-sdk/blob/8bfcf554275c1efbb42666cc8510d2da139b67fa/proto/cosmos/staking/v1beta1/tx.proto#L66-L69


This is an automatic backport of pull request #4402 done by Mergify.

* Fix gentx parser into the cosmosutil package because the use of Delegator Address in MsgCreateValidator is deprecated

* add changelog

(cherry picked from commit bf2539d)

# Conflicts:
#	ignite/pkg/cosmosutil/gentx.go
@mergify mergify bot added the conflicts label Nov 11, 2024
@mergify mergify bot requested a review from ilgooz as a code owner November 11, 2024 20:45
Copy link
Contributor Author

mergify bot commented Nov 11, 2024

Cherry-pick of bf2539d has failed:

On branch mergify/bp/release/v28.x.y/pr-4402
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit bf2539d6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   changelog.md
	modified:   ignite/pkg/cosmosutil/gentx_test.go
	modified:   ignite/pkg/cosmosutil/testdata/gentx2.json

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ignite/pkg/cosmosutil/gentx.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@julienrbrt
Copy link
Member

The original PR shouldn't have been merged because require tests were failing.

@julienrbrt julienrbrt closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants