Improved logging

igniterealtime · Jan 14, 2025 · edf1570 · edf1570
1 parent fd6dd0c
commit edf1570
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/xmppserver/src/main/java/org/jivesoftware/openfire/session/ClientSessionTask.java b/xmppserver/src/main/java/org/jivesoftware/openfire/session/ClientSessionTask.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2007-2009 Jive Software, 2021-2023 Ignite Realtime Foundation. All rights reserved.
+ * Copyright (C) 2007-2009 Jive Software, 2021-2025 Ignite Realtime Foundation. All rights reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -38,7 +38,7 @@
  */
 public class ClientSessionTask extends RemoteSessionTask {
 
-    private static Logger logger = LoggerFactory.getLogger(ClientSessionTask.class);
+    private static final Logger logger = LoggerFactory.getLogger(ClientSessionTask.class);
 
     private JID address;
     private transient Session session;
@@ -61,7 +61,7 @@ Session getSession() {
 
     public void run() {
         if (getSession() == null || getSession().isClosed()) {
-            logger.error("Session not found for JID: " + address);
+            logger.error("Unable to execute task for JID {}: {}", address, this, new IllegalStateException("Session not found for JID: " + address));
             return;
         }
         super.run();

diff --git a/xmppserver/src/main/java/org/jivesoftware/openfire/spi/RoutingTableImpl.java b/xmppserver/src/main/java/org/jivesoftware/openfire/spi/RoutingTableImpl.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2005-2008 Jive Software, 2016-2024 Ignite Realtime Foundation. All rights reserved.
+ * Copyright (C) 2005-2008 Jive Software, 2016-2025 Ignite Realtime Foundation. All rights reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -414,7 +414,8 @@ private boolean routeToLocalDomain(JID jid, Packet packet)
                         routed = remotePacketRouter
                                 .routePacket(clientRoute.getNodeID().toByteArray(), jid, packet);
                         if (!routed) {
-                            removeClientRoute(jid); // drop invalid client route
+                            Log.warn("Dropping invalid client route for {}", jid);
+                            removeClientRoute(jid);
                         }
                     }
                 }