Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement vim-like commands in footer #298

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement vim-like commands in footer #298

wants to merge 1 commit into from

Conversation

ihabunek
Copy link
Owner

Proof of concept, supports only :quit and :help.

@ihabunek
Copy link
Owner Author

@danschwarz Playing around with vim style commands. This PR is a proof of concept, only implements :quit and :help. If you have some time check it out and see if it works well.

@danschwarz
Copy link
Collaborator

danschwarz commented Jan 24, 2023

Works fine; consider adding

self.tui.loop.set_alarm_in(3, lambda *args: self.tui.footer.clear_message())

after

self.close(False, f"Unknown command: {command}")

Copy link
Collaborator

@danschwarz danschwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine and should be expanded.

Right now there are a lot of key bindings, some are non-intuitive. Could move the less frequently used commands to the vim interface and get them out of the key bindings.

Consider adding

self.tui.loop.set_alarm_in(3, lambda *args: self.tui.footer.clear_message())

after

self.close(False, f"Unknown command: {command}")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants