Add harmonisation #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jkikstra next one to play around with (few things left for me to tidy, but worth being aware of) |
|
Clean up done |
|
Probably have to review this one locally, github is not liking trying to preview all the files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds harmonisation, see
notebooks/0510_harmonise-scenarios.py.The underlying idea is that
gcageswill be split into its own package (https://github.com/openscm/gcages) but I've kept it local for now to help development ease and speed. I've checked that I can reproduce the AR6 database harmonisation withgcages(hence the thousands of test files) so we have a clear base from which to change things. I figured that climate-assessment was way too hard to try and refactor so just doing a clean start was going to be easier (given it took 6 hours to spin upgcagesto fully reproducing the checks and harmonisation, which are the hardest part, I'm pretty comfortable with that decision but happy to discuss further if you want).