Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installed update-workspace-root-version #152

Merged
merged 1 commit into from
Aug 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,10 @@ Here are some guidelines to help you and everyone else.
GITHUB_TOKEN=<YOUR_PERSONAL_ACCESS_TOKEN> pnpm release:changelog
```

1. The workspace root's version (e.g. `0.1.3`) is more of an identifier than a (semantic) version. We will use it to name the tag that will be published.

In the root `package.json`, update the version following the "highest-version" formula:
The `release:changelog` script also updated the workspace root's version (by following the highest version formula). We will use it to name the tag that will be published.

```
# Highest version formula
workspace root version = max(
max(all package versions),
workspace root version + 0.0.1,
Expand Down
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"lint": "pnpm --filter '*' lint",
"lint:fix": "pnpm --filter '*' lint:fix",
"prepare": "pnpm --filter './packages/**' --filter my-v2-addon build",
"release:changelog": "changeset version",
"release:changelog": "changeset version; update-workspace-root-version",
"release:publish": "pnpm build && changeset publish",
"start": "concurrently 'pnpm:start:*' --restart-after 5000 --prefix-colors cyan,white,yellow",
"start:embroider-css-modules": "pnpm --filter embroider-css-modules start",
Expand All @@ -29,7 +29,8 @@
"devDependencies": {
"@changesets/cli": "^2.27.7",
"@changesets/get-github-info": "^0.6.0",
"concurrently": "^8.2.2"
"concurrently": "^8.2.2",
"update-workspace-root-version": "^0.3.0"
},
"packageManager": "[email protected]",
"engines": {
Expand Down
42 changes: 15 additions & 27 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.