breaking changes

ikeman32 · Feb 3, 2022 · 3491f32 · 3491f32
1 parent 0869637
commit 3491f32
Show file tree

Hide file tree

Showing 9 changed files with 18 additions and 24 deletions.
diff --git a/README.md b/README.md
@@ -6,6 +6,17 @@ react-router-dom 6.1.1.
 
 ## How To Install
 
+## Breaking changes 
+There are some issues with some of the node pmodules requiring vulnerable versions of certain modules and you may encounter a similar error as this:
+
+Compiled with problems:
+
+ERROR in ./node_modules/history/index.js
+
+and a stack trace through multiple files ending up with webpack compiling with an error.
+Right now the workaround is to run npm audit fix --force to install the breaking changes and vulnerable modules.
+
+
 requires create-react-app v5.0.0
 to force your system to use create-react-app v5 append '@5.0.0' to the create-react-app
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "cra-template-duke",
-  "version": "1.2.2",
+  "version": "1.2.3",
   "description": "Create React App Template",
   "main": "template.json",
   "scripts": {

diff --git a/template.json b/template.json
@@ -12,7 +12,6 @@
       "react-is": "^17.0.2",
       "react-router-dom": "^6.1.1",
       "react-scripts": "^5.0.0",
-      "sass": "^1.45.0",
       "styled-components": "^5.3.3"
     }
   }

diff --git a/template/src/App.js b/template/src/App.js
@@ -1,7 +1,6 @@
 import * as React from 'react';
 import MyRoutes from './components/routes/Routes';//Import routes
 import { Header, StickyFooter, sections, title } from "./components/index";
-import './App.scss';
 
 function App() {
   return (

diff --git a/template/src/App.scss b/template/src/App.scss
diff --git a/template/src/components/index.js b/template/src/components/index.js
@@ -1,11 +1,15 @@
 //Import your custom components here
 import Header from './header/Header';
 import StickyFooter from './footer/StickeyFooter';
+import { sections, title } from './header/HeaderProps';
 
 //Then export them here
 export {
     Header,
-    StickyFooter
+    StickyFooter,
+    sections,
+    title
+
 };
 
 /*

diff --git a/template/src/index.js b/template/src/index.js
@@ -1,7 +1,6 @@
 import * as React from "react";
 import ReactDOM from "react-dom";
 import { BrowserRouter as Router } from "react-router-dom";
-import "./index.scss";
 import App from "./App";
 
 ReactDOM.render(

diff --git a/template/src/index.scss b/template/src/index.scss
diff --git a/template/src/routes/Routes.js b/template/src/routes/Routes.js
@@ -12,7 +12,7 @@ const MyRoutes = () => {
     <>
       <Routes>
         <Route exact path="/" element={<Home />} />
-        <Route path="/About" component={<About />} />
+        <Route path="/About" element={<About />} />
       </Routes>
       {/* <Route path='/<pathname here>' element={<component-name />}/> */}
     </>