Skip subgid check #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks I like the idea. Nowadays it's rather given that user has the sub{g,u}id set. Where as at the time I wrote the playbooks, it typically wasn't there. I'd like to ask a slight change. I still believe the check is in place, because if not, things won't work. So Instead of not including the task, please allow it to check it always the files, but just make the update conditional. And fail if the line is missing and update is disabled. |
added 3 commits
December 16, 2021 11:58
Adding subgids and subguids is not needed anymore since useradd adds them automatically. The addition implemented here only works for the first user (id 1000 with subids starting from 100000). For other users it leads to overlapping subuid/subgid ranges which might lead to very confusing issues when running containers. The addition is left here in case someone is using it or wants to override default ids with some specific values. Fixes ikke-t#34
It feels appropriate to mention this alternative since the author of the anti-pattern article seems to propose this approach too (in the more recent comments of the article).
"find" module only checks that files exist in a directory. In this case it did not fail since the path was a file but there was a warning: TASK [ikke_t.podman_container_systemd : check if user is in subuid file] *********************** [WARNING]: Skipped '/etc/subuid' path due to this access issue: '/etc/subuid' is not a directory ok: [hostname]
jonppe
force-pushed
the
skip_subgid_check
branch
from
9f72011
to
05e11de
Compare
|
I changed the implementation as proposed. |
ikke-t
reviewed
Sep 14, 2022
| find: | ||
| path: /etc/subuid | ||
| contains: '^{{ container_run_as_user }}:.*$' | ||
| shell: "grep -i '^{{ container_run_as_user}}:.*' /etc/subuid" |
There was a problem hiding this comment.
I'd rather not drop to shell for things ansible can handle natively
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable setting subuid and subgid by default.
Add minor comment about alternatives to include_role.