Add 3D filters #22
Open
Add 3D filters #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std::size_t tends to play better with various C++ containers. An explicit float type should be enough (we'll need to create separate library symbols for other types anyway).
Also, remove LIKELY/UNLIKELY macro: they are unused, and available in Highway if needed.
Inside-out dimension order is more convenient to work with: 2D could be processed as 3D with the Z dimension set to 1.
On Linux, it seems position-independent code is required.
Also skip tests that require fastfilters v1 if it is not available.
* Reorganize a lot of things * Add `window_ratio` parameter * Add compatibility module with v1 * Add type annotations * Simplify tests by parametrizing over filter type
* Release GIL before calling into filter implementations * Use floor(x + 0.5) instead of round(x) as in fastfilters v1 * Remove unused imports * Use unaligned loads/stores everywhere * Return channels as the outermost dimension in compat module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support 3D inputs for filters.
Also change interface, and a lot of internal implementation details.
Now filters are computed separately.