Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Ember Flatpickr Addon #8072

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Use Ember Flatpickr Addon #8072

wants to merge 1 commit into from

Conversation

jrjohnson
Copy link
Member

This addon seems to be well maintained and works well. Using it instead of our custom component means we can drop some of the modifiers and possibly help with some of our flaky tests.

WIP:

  • replace the rollover picker as well
  • Feedback from testing
  • Remove flatpickr dependency
  • Possibly replace our test helpers with those provided from the addon

@jrjohnson
Use Ember Glatpickr Addon
81ed589 
This addon seems to be well maintained and works well. Using it instead
of our custom component means we can drop some of the modifiers and
possibly help with some of our flaky tests.
@jrjohnson jrjohnson changed the title Use Ember Glatpickr Addon Use Ember Flatpickr Addon Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelchadwick michaelchadwick Awaiting requested review from michaelchadwick michaelchadwick will be requested when the pull request is marked ready for review michaelchadwick is a code owner

@stopfstedt stopfstedt Awaiting requested review from stopfstedt stopfstedt will be requested when the pull request is marked ready for review stopfstedt is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jrjohnson