replaces ember-render-modifiers with custom modifier in DatePicker component #8312
+197
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopfstedt
force-pushed
the
date-picker-modifier
branch
6 times, most recently
from
6664ee8 to
ea20ce3
Compare
stopfstedt
force-pushed
the
date-picker-modifier
branch
from
ea20ce3 to
5d2e82a
Compare
stopfstedt
requested review from
jrjohnson and
michaelchadwick
as code owners
jrjohnson
approved these changes
Jan 23, 2025
both files are 4k large uncompressed combined, gzip compressed it's a little more than 1k. extracting these imports removes async/await altogether from the task that sets up the picker. that's a worthwhile tradeoff imo.
in the current version, changes to the locale are not registered by the picker - we'll remain in English. declaring the locale as input allows us to be responsive here.
the flatpickr locale handling is inconsistent - if you give it a locale identifier, like we do by default with `en`, and then try to get that back from the picker instance, you'll get an object. handling it this way is much cleaner, at the expense of adding another property. it also gets us around having to compare object to object for non-english locales.
it's been a while since this was kludged in. let's see if we can consistently roll high without it now.
…current locale as input to the modifier.
…t locale if none was given.
stopfstedt
force-pushed
the
date-picker-modifier
branch
from
5d2e82a to
8106566
Compare
stopfstedt
force-pushed
the
date-picker-modifier
branch
from
8106566 to
b59fb0e
Compare
jrjohnson
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs ilios/ilios#5374
components that use the
DatePickercomponent: