Removed render modifiers from Daily/Weekly calendar #8326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelchadwick
requested review from
jrjohnson and
stopfstedt
as code owners
|
NTS: Try to use the existing |
…-component modifier instead
|
OK, simplified the whole thing and changed to an in-component |
stopfstedt
requested changes
Jan 27, 2025
|
|
||
| if (earliestHour < 24 && earliestHour > 2) { | ||
| hourElement = this[`hour${earliestHour}`]; | ||
| hourElement = document.getElementsByClassName(`hour-${earliestHour}`)[0]; |
There was a problem hiding this comment.
Suggested change
| hourElement = document.getElementsByClassName(`hour-${earliestHour}`)[0]; | |
| hourElement = element.getElementsByClassName(`hour-${earliestHour}`)[0]; |
| let hourElement = this.hour6; | ||
| scrollView = modifier((element, [earliestHour]) => { | ||
| // all of the hour elements are registered in the template as hour-0, hour-1, etc | ||
| let hourElement = document.getElementsByClassName(`hour-6`)[0]; |
There was a problem hiding this comment.
Suggested change
| let hourElement = document.getElementsByClassName(`hour-6`)[0]; | |
| let hourElement = element.getElementsByClassName(`hour-6`)[0]; |
|
|
||
| if (earliestHour < 24 && earliestHour > 2) { | ||
| hourElement = this[`hour${earliestHour}`]; | ||
| hourElement = document.getElementsByClassName(`hour-${earliestHour}`)[0]; |
There was a problem hiding this comment.
Suggested change
| hourElement = document.getElementsByClassName(`hour-${earliestHour}`)[0]; | |
| hourElement = element.getElementsByClassName(`hour-${earliestHour}`)[0]; |
| let hourElement = this.hour6; | ||
| scrollView = modifier((element, [earliestHour]) => { | ||
| // all of the hour elements are registered in the template as hour-0, hour-1, etc | ||
| let hourElement = document.getElementsByClassName(`hour-6`)[0]; |
There was a problem hiding this comment.
suggesting to anchor this query to the passed-in container element instead of the document root note.
scoping this down reduces churn and prevents potential class-name collisions.
Suggested change
| let hourElement = document.getElementsByClassName(`hour-6`)[0]; | |
| let hourElement = element.getElementsByClassName(`hour-6`)[0]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs ilios/ilios#5374
Couldn't figure any other way out, so I basically re-created
{{did-update}}as a custom modifier calledon-update. All it does it take in an event to listen for, and run a callback with an argument. This meant changing the scroll mechanism from atask-like call to a simple@action.No idea if this is the way we want to approach stuff like this, but it's a start!