Merge pull request #26 from stopfstedt/rm_unnecessary_exception_rethr…

…owing rm unnecessary try/catch block around the Ilios client instantiation.
ilios · Oct 14, 2024 · f5c78a2 · f5c78a2
2 parents 133cad9 + 31ae556
commit f5c78a2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/classes/form/create_sync_job.php b/classes/form/create_sync_job.php
@@ -76,8 +76,9 @@ public function definition(): void {
             $roleoptions[$role->id] = $role->localname;
         }
 
+        $iliosclient = di::get(ilios::class);
+
         try {
-            $iliosclient = di::get(ilios::class);
             $iliosschools = $iliosclient->get_schools();
             if (!empty($iliosschools)) {
                 $iliosschools = array_column($iliosschools, 'title', 'id');

diff --git a/classes/task/sync_task.php b/classes/task/sync_task.php
@@ -77,12 +77,7 @@ public function execute(): void {
             return;
         }
 
-        try {
-            $iliosclient = di::get(ilios::class);
-        } catch (Exception $e) {
-            // Re-throw exception.
-            throw new Exception('ERROR: Failed to instantiate Ilios client.', $e);
-        }
+        $iliosclient = di::get(ilios::class);
 
         // Run enabled each sync job.
         foreach ($syncjobs as $syncjob) {