Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/company search #57

Merged
merged 5 commits into from
Aug 5, 2024
Merged

Feature/company search #57

merged 5 commits into from
Aug 5, 2024

Conversation

Romstone
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
zero-company-api ⬜️ Ignored (Inspect) Aug 5, 2024 6:48pm

@iliubinskii
Copy link
Owner

First, you duplicate this fragment in buildFilter and getCompanies. Let's leave keep this logic in buildFilter:
image

Second, regular expressions ($regex: q) is not a good option here. End users are not supposed to know how to use them. Let's try this instead:
image

But note that we use Mongoose (not plain MongoDB):
image

@iliubinskii iliubinskii merged commit 930a7a7 into develop Aug 5, 2024
5 checks passed
@iliubinskii iliubinskii deleted the feature/company-search branch August 6, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants